Skip to content

Conversation

@cijothomas
Copy link
Member

@cijothomas cijothomas commented Aug 2, 2025

Removed this from testing module:

impl TraceId {
    pub fn from_u128(num: u128) -> Self {
        TraceId::from_bytes(num.to_be_bytes())
    }
}

/// Helper to create span ids for testing
impl SpanId {
    pub fn from_u64(num: u64) -> Self {
        SpanId::from_bytes(num.to_be_bytes())
    }
}

as the below already exists!

impl From<u128> for TraceId {
    fn from(value: u128) -> Self {
        TraceId(value)
    }
}

impl From<u64> for SpanId {
    fn from(value: u64) -> Self {
        SpanId(value)
    }
}

@cijothomas cijothomas requested a review from a team as a code owner August 2, 2025 00:13
@codecov
Copy link

codecov bot commented Aug 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.1%. Comparing base (0462369) to head (b89c13d).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3103     +/-   ##
=======================================
- Coverage   80.1%   80.1%   -0.1%     
=======================================
  Files        126     126             
  Lines      21957   21955      -2     
=======================================
- Hits       17603   17601      -2     
  Misses      4354    4354             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gruebel gruebel changed the title chore: Remove unwanted from implementation for TraceId SpanIs chore: Remove unwanted from implementation for TraceId and SpanId Aug 4, 2025
@cijothomas cijothomas merged commit fa15073 into open-telemetry:main Aug 4, 2025
29 checks passed
@cijothomas cijothomas deleted the cijothomas/tracecleanup branch August 4, 2025 15:57
bantonsson pushed a commit to bantonsson/opentelemetry-rust that referenced this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants